Add `ErrorCodeOverride` to error structs #401

eddy-aws · 2022-12-07T07:25:22Z

Description of changes:
Makes changes to AwsJson protocol generator.

Introduces ErrorCodeOverride field to error structs
Returns ErrorCodeOverride if not empty. Else returns default error code
Introduces generateErrorShape method to allow override default error block for unmodeled errors

For example, AWS code bases would have something like the following to override generateErrorShape:

    @Override
    protected Set<StructureShape> generateErrorShapes(
        GenerationContext context, OperationShape operation, Symbol responseType) {
        if (isAwsQueryCompatibleTraitFound(context)) {
            return HttpProtocolGeneratorUtils.generateErrorDispatcher(
                context, operation, responseType, this::writeErrorMessageCodeDeserializer,
                this::getOperationErrors, (writer) -> AwsJsonRpc1_0.awsQueryCompatibleDefaultBlockWriter(writer));
        } else {
            return HttpProtocolGeneratorUtils.generateErrorDispatcher(
                context, operation, responseType, this::writeErrorMessageCodeDeserializer,
                this::getOperationErrors);
        }
    }

    private static void awsQueryCompatibleDefaultBlockWriter(GoWriter writer) {
        writer.openBlock("default:", "", () -> {
            writer.openBlock("genericError := &smithy.GenericAPIError{", "}", () -> {
                    writer.write("Code: getAwsQueryErrorCode(response),");
                writer.write("Message: errorMessage,");
            });
            writer.write("return genericError");
        });
    }

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

syall · 2022-12-07T11:16:18Z

There should not be any AWS-specific code in generic smithy code generators.

isaiahvita · 2022-12-07T16:26:29Z

agree with @syall, AWS logic should be in the codegen module in the V2 package. only generic service (not AWS specific) code generation logic should be in smithy-go

...en/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/StructureGenerator.java

isaiahvita · 2022-12-12T15:58:10Z

just to clarify the intent behind:

Introduces generateErrorShape method to allow override default error block for unmodeled errors

It looks like the plan is in service-specific codebases (in our case, the aws codebase) to override generateErrorShapes to call the newgenerateErrorDispatcher with a different DefaultBlockWriter, and the reason you made the existing generateErrorDispatcher function public is so that the overloaded functions can having matching privacy annotations?

eddy-aws · 2022-12-12T16:05:26Z

just to clarify the intent behind:

Introduces generateErrorShape method to allow override default error block for unmodeled errors

I have updated the description with some additional details

...en/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/StructureGenerator.java

.../src/main/java/software/amazon/smithy/go/codegen/integration/HttpProtocolGeneratorUtils.java

...en/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/StructureGenerator.java

This change regnerates clients for the smithy-go change - aws/smithy-go#401 Adds Code field to all errors. Modifies ErrorCode method to return Code if present.

codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/SymbolVisitor.java

Adds `ErrorCodeOverride` field to all error structs, and modifies the `ErrorCode()` method to return `ErrorCodeOverride` if present. This change regenerates clients for aws/smithy-go#401.

syall

Rebased changes, but will need to Squash commits before merging.

Adds `ErrorCodeOverride` field to all error structs, and modifies the `ErrorCode()` method to return `ErrorCodeOverride` if present. This change regenerates clients for aws/smithy-go#401.

Adding the `ErrorCodeOverride` field allows protocols to override the default `ErrorCode()` implementation (which is the name of the error) with a custom string. If a smithy model uses the `ErrorCodeOverride` field in an error structure, it will be renamed to `ErrorCodeOverride_`. Also, the writer for the switch-statement default block is now pluggable, which means the default block can be overwritten with a custom writer.

Adds `ErrorCodeOverride` field to all error structs, and modifies the `ErrorCode()` method to return `ErrorCodeOverride` if present. This change regenerates clients for aws/smithy-go#401.

… to 1.30.0 (#6578) Bumps [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2) from 1.27.1 to 1.30.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md">github.com/aws/aws-sdk-go-v2/service/s3's changelog</a>.</em></p> <blockquote> <h1>Release (2023-01-10)</h1> <h2>Module Highlights</h2> <ul> <li><code>github.com/aws/aws-sdk-go-v2/service/location</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/main/service/location/CHANGELOG.md#v1210-2023-01-10">v1.21.0</a> <ul> <li><strong>Feature</strong>: This release adds support for two new route travel models, Bicycle and Motorcycle which can be used with Grab data source.</li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/rds</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/main/service/rds/CHANGELOG.md#v1400-2023-01-10">v1.40.0</a> <ul> <li><strong>Feature</strong>: This release adds support for configuring allocated storage on the CreateDBInstanceReadReplica, RestoreDBInstanceFromDBSnapshot, and RestoreDBInstanceToPointInTime APIs.</li> </ul> </li> </ul> <h1>Release (2023-01-09)</h1> <h2>Module Highlights</h2> <ul> <li><code>github.com/aws/aws-sdk-go-v2/service/ecrpublic</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/main/service/ecrpublic/CHANGELOG.md#v1150-2023-01-09">v1.15.0</a> <ul> <li><strong>Feature</strong>: This release for Amazon ECR Public makes several change to bring the SDK into sync with the API.</li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/kendraranking</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/main/service/kendraranking/CHANGELOG.md#v100-2023-01-09">v1.0.0</a> <ul> <li><strong>Release</strong>: New AWS service client module</li> <li><strong>Feature</strong>: Introducing Amazon Kendra Intelligent Ranking, a new set of Kendra APIs that leverages Kendra semantic ranking capabilities to improve the quality of search results from other search services (i.e. OpenSearch, ElasticSearch, Solr).</li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/networkfirewall</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/main/service/networkfirewall/CHANGELOG.md#v1230-2023-01-09">v1.23.0</a> <ul> <li><strong>Feature</strong>: Network Firewall now supports the Suricata rule action reject, in addition to the actions pass, drop, and alert.</li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/workspacesweb</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/main/service/workspacesweb/CHANGELOG.md#v190-2023-01-09">v1.9.0</a> <ul> <li><strong>Feature</strong>: This release adds support for a new portal authentication type: AWS IAM Identity Center (successor to AWS Single Sign-On).</li> </ul> </li> </ul> <h1>Release (2023-01-06)</h1> <h2>Module Highlights</h2> <ul> <li><code>github.com/aws/aws-sdk-go-v2/service/acmpca</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/main/service/acmpca/CHANGELOG.md#v1210-2023-01-06">v1.21.0</a> <ul> <li><strong>Feature</strong>: Added revocation parameter validation: bucket names must match S3 bucket naming rules and CNAMEs conform to RFC2396 restrictions on the use of special characters in URIs.</li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/auditmanager</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/main/service/auditmanager/CHANGELOG.md#v1230-2023-01-06">v1.23.0</a> <ul> <li><strong>Feature</strong>: This release introduces a new data retention option in your Audit Manager settings. You can now use the DeregistrationPolicy parameter to specify if you want to delete your data when you deregister Audit Manager.</li> </ul> </li> </ul> <h1>Release (2023-01-05)</h1> <h2>General Highlights</h2> <ul> <li><strong>Dependency Update</strong>: Updated to the latest SDK module versions</li> </ul> <h2>Module Highlights</h2> <ul> <li><code>github.com/aws/aws-sdk-go-v2/service/accessanalyzer</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/main/service/accessanalyzer/CHANGELOG.md#v1190-2023-01-05">v1.19.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/account</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/main/service/account/CHANGELOG.md#v180-2023-01-05">v1.8.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/acm</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/main/service/acm/CHANGELOG.md#v1170-2023-01-05">v1.17.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/acmpca</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/main/service/acmpca/CHANGELOG.md#v1200-2023-01-05">v1.20.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/alexaforbusiness</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/main/service/alexaforbusiness/CHANGELOG.md#v1150-2023-01-05">v1.15.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/amp</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/main/service/amp/CHANGELOG.md#v1160-2023-01-05">v1.16.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/amplify</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/main/service/amplify/CHANGELOG.md#v1130-2023-01-05">v1.13.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/amplifybackend</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/main/service/amplifybackend/CHANGELOG.md#v1140-2023-01-05">v1.14.0</a></li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/116a622a26e2b4c0a47749c132faaee81ff76b7e"><code>116a622</code></a> Release 2023-01-05</li> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/ce039452b6a7e2046ee8e6292260cc9d1e78af7e"><code>ce03945</code></a> Regenerated Clients</li> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/095bbfff591b1bccef0d87f315171cf9b2a1db2f"><code>095bbff</code></a> Update API model</li> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/2998a9800a670c002b68787fa37b059f1bd57674"><code>2998a98</code></a> Regenerate clients with <code>ErrorCodeOverride</code> (<a href="https://github-redirect.dependabot.com/aws/aws-sdk-go-v2/issues/1969">#1969</a>)</li> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/1b0a07d93d9e22efb8b426e4025bca10b0d9c296"><code>1b0a07d</code></a> Release 2023-01-04</li> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/ff5b1c7a27c061145c37e8169a285a91a2aabc6c"><code>ff5b1c7</code></a> Regenerated Clients</li> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/cabea36bb4efa8711271d6dac95e4666efe8a4b4"><code>cabea36</code></a> Update API model</li> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/cd385dc3b81a32b8f75a499259b4139a7634058c"><code>cd385dc</code></a> Update links to point to smithy.io</li> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/4dd79b8978186cc289c7e2eb70b14d40ec179051"><code>4dd79b8</code></a> Rename SyntheticClone to Synthetic</li> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/b302f0a86c80ee4c17b0a3d1f30871d7a9cb8a93"><code>b302f0a</code></a> Release 2023-01-03</li> <li>Additional commits viewable in <a href="https://github.com/aws/aws-sdk-go-v2/compare/service/s3/v1.27.1...service/s3/v1.30.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/aws/aws-sdk-go-v2/service/s3&package-manager=go_modules&previous-version=1.27.1&new-version=1.30.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

….3 to 1.30.0 in /src (#269) Bumps [github.com/aws/aws-sdk-go-v2/service/secretsmanager](https://github.com/aws/aws-sdk-go-v2) from 1.29.3 to 1.30.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/CHANGELOG.md">github.com/aws/aws-sdk-go-v2/service/secretsmanager's changelog</a>.</em></p> <blockquote> <h1>Release (2023-01-05)</h1> <h2>General Highlights</h2> <ul> <li><strong>Dependency Update</strong>: Updated to the latest SDK module versions</li> </ul> <h2>Module Highlights</h2> <ul> <li><code>github.com/aws/aws-sdk-go-v2/service/accessanalyzer</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/accessanalyzer/CHANGELOG.md#v1190-2023-01-05">v1.19.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/account</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/account/CHANGELOG.md#v180-2023-01-05">v1.8.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/acm</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/acm/CHANGELOG.md#v1170-2023-01-05">v1.17.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/acmpca</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/acmpca/CHANGELOG.md#v1200-2023-01-05">v1.20.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/alexaforbusiness</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/alexaforbusiness/CHANGELOG.md#v1150-2023-01-05">v1.15.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/amp</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/amp/CHANGELOG.md#v1160-2023-01-05">v1.16.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/amplify</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/amplify/CHANGELOG.md#v1130-2023-01-05">v1.13.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/amplifybackend</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/amplifybackend/CHANGELOG.md#v1140-2023-01-05">v1.14.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> <li><strong>Feature</strong>: Updated GetBackendAPIModels response to include ModelIntrospectionSchema json string</li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/amplifyuibuilder</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/amplifyuibuilder/CHANGELOG.md#v190-2023-01-05">v1.9.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/apigateway</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/apigateway/CHANGELOG.md#v1160-2023-01-05">v1.16.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/apigatewaymanagementapi</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/apigatewaymanagementapi/CHANGELOG.md#v1110-2023-01-05">v1.11.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/apigatewayv2</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/apigatewayv2/CHANGELOG.md#v1130-2023-01-05">v1.13.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/appconfig</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/appconfig/CHANGELOG.md#v1150-2023-01-05">v1.15.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/appconfigdata</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/appconfigdata/CHANGELOG.md#v150-2023-01-05">v1.5.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/appflow</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/appflow/CHANGELOG.md#v1230-2023-01-05">v1.23.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/appintegrations</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/appintegrations/CHANGELOG.md#v1140-2023-01-05">v1.14.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/applicationautoscaling</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/applicationautoscaling/CHANGELOG.md#v1170-2023-01-05">v1.17.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/applicationcostprofiler</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/applicationcostprofiler/CHANGELOG.md#v1100-2023-01-05">v1.10.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/applicationdiscoveryservice</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/applicationdiscoveryservice/CHANGELOG.md#v1150-2023-01-05">v1.15.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/applicationinsights</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/applicationinsights/CHANGELOG.md#v1170-2023-01-05">v1.17.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/appmesh</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/appmesh/CHANGELOG.md#v1170-2023-01-05">v1.17.0</a> <ul> <li><strong>Feature</strong>: Add <code>ErrorCodeOverride</code><code>aws/smithy-go#401</code></li> </ul> </li> <li><code>github.com/aws/aws-sdk-go-v2/service/apprunner</code>: <a href="https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.30.0/service/apprunner/CHANGELOG.md#v1160-2023-01-05">v1.16.0</a></li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/116a622a26e2b4c0a47749c132faaee81ff76b7e"><code>116a622</code></a> Release 2023-01-05</li> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/ce039452b6a7e2046ee8e6292260cc9d1e78af7e"><code>ce03945</code></a> Regenerated Clients</li> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/095bbfff591b1bccef0d87f315171cf9b2a1db2f"><code>095bbff</code></a> Update API model</li> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/2998a9800a670c002b68787fa37b059f1bd57674"><code>2998a98</code></a> Regenerate clients with <code>ErrorCodeOverride</code> (<a href="https://redirect.github.com/aws/aws-sdk-go-v2/issues/1969">#1969</a>)</li> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/1b0a07d93d9e22efb8b426e4025bca10b0d9c296"><code>1b0a07d</code></a> Release 2023-01-04</li> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/ff5b1c7a27c061145c37e8169a285a91a2aabc6c"><code>ff5b1c7</code></a> Regenerated Clients</li> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/cabea36bb4efa8711271d6dac95e4666efe8a4b4"><code>cabea36</code></a> Update API model</li> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/cd385dc3b81a32b8f75a499259b4139a7634058c"><code>cd385dc</code></a> Update links to point to smithy.io</li> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/4dd79b8978186cc289c7e2eb70b14d40ec179051"><code>4dd79b8</code></a> Rename SyntheticClone to Synthetic</li> <li><a href="https://github.com/aws/aws-sdk-go-v2/commit/b302f0a86c80ee4c17b0a3d1f30871d7a9cb8a93"><code>b302f0a</code></a> Release 2023-01-03</li> <li>Additional commits viewable in <a href="https://github.com/aws/aws-sdk-go-v2/compare/service/s3/v1.29.3...service/s3/v1.30.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/aws/aws-sdk-go-v2/service/secretsmanager&package-manager=go_modules&previous-version=1.29.3&new-version=1.30.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

eddy-aws requested a review from a team as a code owner December 7, 2022 07:25

isaiahvita reviewed Dec 7, 2022

View reviewed changes

...en/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/StructureGenerator.java Outdated Show resolved Hide resolved

eddy-aws changed the title ~~Add AwsQueryCompatibleTrait support~~ Introduce Code field to error structs Dec 12, 2022

syall suggested changes Dec 13, 2022

View reviewed changes

eddy-aws added a commit to eddy-aws/aws-sdk-go-v2 that referenced this pull request Dec 19, 2022

Regenerate clients

532eac4

This change regnerates clients for the smithy-go change - aws/smithy-go#401 Adds Code field to all errors. Modifies ErrorCode method to return Code if present.

eddy-aws added a commit to eddy-aws/aws-sdk-go-v2 that referenced this pull request Dec 19, 2022

Regenerate clients

7da3688

This change regnerates clients for the smithy-go change - aws/smithy-go#401 Adds Code field to all errors. Modifies ErrorCode method to return Code if present.

eddy-aws mentioned this pull request Dec 19, 2022

Regenerate clients aws/aws-sdk-go-v2#1964

Closed

eddy-aws added a commit to eddy-aws/aws-sdk-go-v2 that referenced this pull request Dec 27, 2022

Regenerate clients

67c5329

This change regnerates clients for the smithy-go change - aws/smithy-go#401 Adds Code field to all errors. Modifies ErrorCode method to return Code if present.

eddy-aws mentioned this pull request Dec 27, 2022

Regenerate clients with ErrorCodeOverride aws/aws-sdk-go-v2#1969

Merged

isaiahvita assigned isaiahvita and syall Dec 27, 2022

syall force-pushed the query-comp branch from 432dffa to a6e6ab2 Compare December 28, 2022 13:59

syall changed the title ~~Introduce Code field to error structs~~ Introduce ErrorCodeOverride field to error structs Dec 28, 2022

syall reviewed Dec 28, 2022

View reviewed changes

codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/SymbolVisitor.java Show resolved Hide resolved

syall approved these changes Dec 28, 2022

View reviewed changes

syall changed the title ~~Introduce ErrorCodeOverride field to error structs~~ Add ErrorCodeOverride to error structs Dec 28, 2022

isaiahvita approved these changes Dec 28, 2022

View reviewed changes

syall force-pushed the query-comp branch from a6e6ab2 to 21eaa6c Compare January 4, 2023 20:23

isaiahvita merged commit 966ca4e into aws:main Jan 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `ErrorCodeOverride` to error structs #401

Add `ErrorCodeOverride` to error structs #401

eddy-aws commented Dec 7, 2022 •

edited by syall

Loading

syall commented Dec 7, 2022

isaiahvita commented Dec 7, 2022 •

edited

Loading

isaiahvita commented Dec 12, 2022

eddy-aws commented Dec 12, 2022

syall left a comment

Add ErrorCodeOverride to error structs #401

Add ErrorCodeOverride to error structs #401

Conversation

eddy-aws commented Dec 7, 2022 • edited by syall Loading

syall commented Dec 7, 2022

isaiahvita commented Dec 7, 2022 • edited Loading

isaiahvita commented Dec 12, 2022

eddy-aws commented Dec 12, 2022

syall left a comment

Choose a reason for hiding this comment

Add `ErrorCodeOverride` to error structs #401

Add `ErrorCodeOverride` to error structs #401

eddy-aws commented Dec 7, 2022 •

edited by syall

Loading

isaiahvita commented Dec 7, 2022 •

edited

Loading